-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1/N] pass the complete config from engine to executor #9933
Conversation
Signed-off-by: youkaichao <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
the path is: Engine --> Executor --> Worker --> ModelRunner --> Model all of them will get the complete engine config object this way, if we have a config field that is only needed by one component, we don't need to change the function signature for all these classes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a nice step in refactoring. I had one suggestion about leaving a TODO note in the code.
+1 this is a nice change |
thanks for your appreciation! the goal is: if we have a config field that is only needed by one component, we don't need to change the function signature for all these classes. (context: I'm going to add a compilation config for |
each component can still save their local copy of configs like |
Signed-off-by: youkaichao <[email protected]>
Signed-off-by: youkaichao <[email protected]>
Signed-off-by: youkaichao <[email protected]>
After this PR, the following command for v1 hangs during startup:
Log:
|
…9933) Signed-off-by: youkaichao <[email protected]>
…9933) Signed-off-by: youkaichao <[email protected]> Signed-off-by: Linkun Chen <[email protected]>
…9933) Signed-off-by: youkaichao <[email protected]> Signed-off-by: Richard Liu <[email protected]>
…9933) Signed-off-by: youkaichao <[email protected]>
Signed-off-by: youkaichao <[email protected]>
Signed-off-by: youkaichao <[email protected]>
…9933) Signed-off-by: youkaichao <[email protected]>
…9933) Signed-off-by: youkaichao <[email protected]> Signed-off-by: Loc Huynh <[email protected]>
…9933) Signed-off-by: youkaichao <[email protected]> Signed-off-by: Sumit Dubey <[email protected]>
…9933) Signed-off-by: youkaichao <[email protected]>
…9933) Signed-off-by: youkaichao <[email protected]> Signed-off-by: Maxime Fournioux <[email protected]>
…9933) Signed-off-by: youkaichao <[email protected]> Signed-off-by: Tyler Michael Smith <[email protected]>
…9933) Signed-off-by: youkaichao <[email protected]>
No description provided.